softarc-consulting / sheriff

Lightweight Modularity for TypeScript Projects
https://softarc-consulting.github.io/sheriff/
MIT License
196 stars 14 forks source link

The autoTagging property does not exist in SheriffConfig #85

Closed gpaglia closed 5 months ago

gpaglia commented 5 months ago

The autoTagging property of SheriffConfig does not exist.

Here's the simple sheriff.config.ts that I used, following the README instructions:

import { SheriffConfig } from '@softarc/sheriff-core';

export const sheriffConfig: SheriffConfig = {
  autoTagging: false,
  tagging: {
    // no tags for now...
  },
  depRules: {
    root: 'noTag',
    noTag: ['noTag', 'root'],
  },
};

and I get the error:

Object literal may only specify known properties, and 'autoTagging' does not exist in type 'SheriffConfig'.ts(2353)
⚠ Error (TS2353) | 
Object literal may only specify known properties, and autoTagging does not exist in type 

My environment:

VSCode:
Version: 1.89.1 (system setup)
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:13:33.891Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.19045

Package.json:

{
  "name": "@kclients/source",
  "version": "0.0.0",
  "license": "MIT",
  "scripts": {},
  "private": true,
  "dependencies": {
    "@angular/animations": "~17.3.0",
    "@angular/cdk": "^17.3.8",
    "@angular/common": "~17.3.0",
    "@angular/compiler": "~17.3.0",
    "@angular/core": "~17.3.0",
    "@angular/forms": "~17.3.0",
    "@angular/material": "^17.3.8",
    "@angular/platform-browser": "~17.3.0",
    "@angular/platform-browser-dynamic": "~17.3.0",
    "@angular/router": "~17.3.0",
    "@nx/angular": "19.0.2",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.3"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~17.3.0",
    "@angular-devkit/core": "~17.3.0",
    "@angular-devkit/schematics": "~17.3.0",
    "@angular-eslint/eslint-plugin": "~17.3.0",
    "@angular-eslint/eslint-plugin-template": "~17.3.0",
    "@angular-eslint/template-parser": "~17.3.0",
    "@angular/cli": "~17.3.0",
    "@angular/compiler-cli": "~17.3.0",
    "@angular/language-service": "~17.3.0",
    "@nx/cypress": "19.0.2",
    "@nx/eslint": "19.0.2",
    "@nx/eslint-plugin": "19.0.2",
    "@nx/jest": "19.0.2",
    "@nx/js": "19.0.2",
    "@nx/web": "19.0.2",
    "@nx/workspace": "19.0.2",
    "@schematics/angular": "~17.3.0",
    "@softarc/eslint-plugin-sheriff": "^0.14.5",
    "@softarc/sheriff-core": "^0.14.5",
    "@swc-node/register": "~1.8.0",
    "@swc/core": "^1.4.13",
    "@swc/helpers": "~0.5.2",
    "@types/jest": "^29.4.0",
    "@types/node": "18.16.9",
    "@typescript-eslint/eslint-plugin": "^7.3.0",
    "@typescript-eslint/parser": "^7.3.0",
    "cypress": "^13.6.6",
    "eslint": "~8.57.0",
    "eslint-config-prettier": "^9.0.0",
    "eslint-plugin-cypress": "^2.13.4",
    "jest": "^29.4.1",
    "jest-environment-jsdom": "^29.4.1",
    "jest-preset-angular": "~14.0.3",
    "nx": "19.0.2",
    "prettier": "^2.6.2",
    "ts-jest": "^29.1.0",
    "ts-node": "10.9.1",
    "typescript": "~5.4.2"
  }
}

Maybe the documentation is outdated, but then how to turn on/off autoTagging?

Thanks a log, gpaglia

rainerhahnekamp commented 5 months ago

Sorry @gpaglia, the documentation was up to date, but for some reason the wrong package has been published. It is now fixed in 0.14.6. Feel free to open a new issue, if you encounter any issues with the auto-tagging

gpaglia commented 5 months ago

Thanks a lot for addressing this so quickly, G

Il sab 11 mag 2024, 20:27 Rainer Hahnekamp @.***> ha scritto:

Sorry @gpaglia https://github.com/gpaglia, the documentation was up to date, but for some reason the wrong package has been published. It is now fixed in 0.14.6. Feel free to open a new issue, if you encounter any issues with the auto-tagging

— Reply to this email directly, view it on GitHub https://github.com/softarc-consulting/sheriff/issues/85#issuecomment-2105982930, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWJ6PCR33A5YUEKZLBEHXDZBZPI3AVCNFSM6AAAAABHR3C7HWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVHE4DEOJTGA . You are receiving this because you were mentioned.Message ID: @.***>

gpaglia commented 5 months ago

Tested and ok, thanks a lot again. G 👍

rainerhahnekamp commented 5 months ago

Great to hear and sorry for the troubles. In our other project ngrx-toolkit, we're already using nx release. Time to do that here as well