search

softashell / iqdb_tagger

Search IQDB from CLI
MIT License
9 stars 5 forks source link

Update program #1

Closed rachmadaniHaryono closed 6 years ago

rachmadaniHaryono commented 7 years ago

hi i made a fork because i need a program to parse result from iqdb.

there are some settings that i deliberately fill based on project and github profile (e.g. setup.py and license)

also it still work in progress but some feature already exist. i will update this if the PR is ready.

softashell commented 6 years ago

Feels weird to be given so much credit when it's based on something that anyone could have put together in a few hours at worst. There's pretty much no reason to merge since this small snippet (at best) is already unmaintained since I never used it past the day I thought I needed it. Should probably get into hydrus as well tbh

rachmadaniHaryono commented 6 years ago

There's pretty much no reason to merge since this small snippet (at best) is already unmaintained since I never used it past the day I thought I needed it.

well, actually it is going from hydrus community. we are looking for a program to get tags from iqdb. and the first python program is this.

i actually learn a lot from this little snippet and not starting from 0 is actually speed things a lot.

why this have to be merged?

first thing is license. this repo don't have license, but that doesn't mean i can just fork it. based on this https://stackoverflow.com/a/13669816/1766261 there is still copyright. so i just don't want any trouble with it. i also added another license (or actually change it) just for easier upload to pypi.

second thing is search result on github search. fork is not included on search result, and if someone searching for iqdb tagger, only old commit is found.

if you don't want to work it again, i recommend 2 possibilites:

  1. add me as contributor, i will manage the project
  2. transfer the repository. i actually hate this choice, but it is better for the project.

i have no idea after almost 6 years from the latest commit, you reply on this pr.

also i will still put your account name on setup.py, but use my email for your author_email. if you want, i can change it.

softashell commented 6 years ago

Completely forgot about this, I added you as a contributor. Feel free to do what you wish with it. I could also just remove this repository or transfer it to you completely since it's mostly sitting here for archival reasons.

rachmadaniHaryono commented 6 years ago

imo add as contributor is enough. i will merge master branch first. later i will fix some link