softbankrobotics-research / qibullet

Bullet simulation for SoftBank Robotics robots
Apache License 2.0
141 stars 38 forks source link

Incorrect Variable Naming in FSR Source Code #93

Open chofdc opened 1 month ago

chofdc commented 1 month ago

I discovered, during my work, an issue in the source code where the variable names for the right foot force-sensitive resistor (FSR) values are incorrectly assigned to the left foot FSR values. This results in both the left and right foot FSR values showing the same values even during walking.

LFOOT_FL = "LFsrFL_frame" LFOOT_FR = "LFsrFR_frame" LFOOT_RL = "LFsrRL_frame" LFOOT_RR = "LFsrRR_frame" RFOOT_FL = "LFsrFL_frame" # Should be "RFsrFL_frame" RFOOT_FR = "LFsrFR_frame" # Should be "RFsrFR_frame" RFOOT_RL = "LFsrRL_frame" # Should be "RFsrRL_frame" RFOOT_RR = "LFsrRR_frame" # Should be "RFsrRR_frame"

LFOOT = [LFOOT_FL, LFOOT_FR, LFOOT_RL, LFOOT_RR] RFOOT = [LFOOT_FL, LFOOT_FR, LFOOT_RL, LFOOT_RR] # Should be [RFOOT_FL, RFOOT_FR, RFOOT_RL, RFOOT_RR]

fsr_issue

This correction will ensure accurate data processing for both left and right foot FSR values.

Thank you for addressing this issue promptly.