softboiler / boilercv

Computer vision routines suitable for nucleate pool boiling bubble analysis
https://softboiler.org/boilercv/
MIT License
0 stars 2 forks source link

Workflows don't run as expected on external PRs #165

Closed blakeNaccarato closed 7 months ago

blakeNaccarato commented 8 months ago

Workflows run in local PRs (e.g. https://github.com/blakeNaccarato/boilercv/pull/163) just fine because those are triggering on push in the configuration below.

https://github.com/blakeNaccarato/boilercv/blob/27219ccbca48e7a909220677f759368ed9001bca/.github/workflows/main.yml#L3

But these workflows don't run in external PRs (e.g. https://github.com/blakeNaccarato/boilercv/pull/164). I will need to add the pull_request trigger for that. However, in the case that an external PR bumps a dependency, would the Renovate and GitHub Actions bots be allowed to push to the remote contributor's branch? Will have to test this.

Performing the steps below directly in this repo (even with branches and PRs) is sort of like a patient operating on themselves, so if functionality breaks at any point, I'll have roll back and revisit other solutions to this problem (where a bot needs to make commits in the incoming branch of local and external PRs alike) and mock up this behavior in a dummy repo.

Tasks

blakeNaccarato commented 7 months ago

Well, nevermind all that. It's fixed with the new workflows developed for syncing/locking environments. I filtered to main on push and introduced the pull_request trigger.