search

softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
507 stars 31 forks source link

Tweak the newlinecache #302

Closed ltratt closed 2 years ago

ltratt commented 2 years ago

This PR tweaks the newline cache stuff a bit: hopefully each commit explains sensibly what it's doing. I do wonder if we should replace the byte_to stuff with span_to? But that would be a future PR...

@ratmice can you review this please? If/when you're happy with it, you can bors it.

bors delegate=ratmice

bors[bot] commented 2 years ago

:v: ratmice can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

ratmice commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build failed:

ratmice commented 2 years ago

Sorry, should have asked if you wanted to squash anything first.

ltratt commented 2 years ago

Hopefully https://github.com/softdevteam/grmtools/pull/302/commits/7ab42aa9305d11e73df17034842bd86212c0730e fixes bors. If you're OK with that, I will need to do a bit of squashing.

bors try

bors[bot] commented 2 years ago

try

Build succeeded:

ratmice commented 2 years ago

Absolutely OK with that.

ltratt commented 2 years ago

Squashed.

ratmice commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: