softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
507 stars 31 forks source link

Doc changes #306

Closed ltratt closed 2 years ago

ltratt commented 2 years ago

This PR slightly tweaks the book (https://github.com/softdevteam/grmtools/commit/89592bc21bda66aa55be8f31f65bec340631182f) before starting to update CHANGES.md while I still vaguely remember what we've done (https://github.com/softdevteam/grmtools/commit/1eb16396ad7b8d9f3ceddb5e27bd4a8c81897a72).

@ratmice In theory (if I've done it right!) you should now be able to bors things without me giving you permission each time!

ratmice commented 2 years ago

The signature of cfgrammar::yacc::YaccGrammar::add_rule changed in a728ac2d55e33bdfcce9d25e341ef402c60e9f5b to accept a (name, span): (String, Span) instead of a name: String

cfgrammar::yacc::YaccGrammar::rule_name was removed, and replaced with cfgrammar::yacc::YaccGrammar::rule_name_str in a728ac2d55e33bdfcce9d25e341ef402c60e9f5b , also rule_name_span was added.

rule_name_str has the same signature as the previous rule_name, so we may want to consider re-adding it as a deprecated alias?

I think that is everything.

ltratt commented 2 years ago

add_rule now documented in 4f98c90.

Readded rule_name in 2654e95 (which I'll keep as a separate commit if/when we come to squashing).

ratmice commented 2 years ago

This looks good to me, Please squash.

ltratt commented 2 years ago

Squashed.

ratmice commented 2 years ago

I am super confused by the compare button, which shows c61a4a970da105e19b645be1d870ab91675f8087, instead of the diff between 265e95 and c8bd556, but I think this is just the github UI having gone awry.

Manual inspection of the commits all looks ok, so I believe that bors should pick up the right changes. But didn't want to pull the trigger on this in case you want to double check.

ltratt commented 2 years ago

Try doing a force reload of the page? That sometimes fixes these transient errors.

ratmice commented 2 years ago

Nope, still showing the wrong diff, not even on this branch.

ratmice commented 2 years ago

bors try

[Just want to double check that bors picks up the right commit, probably being overly cautious though]

bors[bot] commented 2 years ago

:lock: Permission denied

Existing reviewers: click here to make ratmice a reviewer

ltratt commented 2 years ago

OK, looks like I didn't get the bors setup right. Bear with.

ltratt commented 2 years ago

Try the "try" again?

ratmice commented 2 years ago

bors try

bors[bot] commented 2 years ago

try

Build succeeded:

ratmice commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: