softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
507 stars 31 forks source link

Unused symbol 3rd #348

Closed ratmice closed 2 years ago

ratmice commented 2 years ago

From https://github.com/softdevteam/grmtools/pull/347#issuecomment-1236191561

  1. In an ideal world I'd like to get something like https://github.com/softdevteam/grmtools/commit/75fb27d4902cb1dbc708509488f8413cab3203dc into master straight away (possibly merging https://github.com/softdevteam/grmtools/commit/9e787622c76f0ab6fdf438887807df80fb99d345 into it?), modelling it exactly on the other expect- rules. Let's not worry about warnings for this. I think this should be its own PR.

This brings in the 2 commits mentioned unmodified from the previous series, on top of that is a patch to remove the dependence on warnings. It runs the check (to avoid warnings, and ensure the testsuite runs it) but doesn't do anything with the result yet. That allowed a small cleanup to remove a temporary vector, since it no longer would capture self in the closure.

As such it will need to be squashed, let me know if you prefer that I do that squash before you want to look at it.

ltratt commented 2 years ago

I think we're ready to squash?

ratmice commented 2 years ago

Squashed, but let me know if you prefer just one commit.

ltratt commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded: