softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
507 stars 31 forks source link

Suggestions from clippy #368

Closed ratmice closed 1 year ago

ratmice commented 1 year ago

I wasn't really sure what we want to do with clippy::derive_partial_eq_without_eq, Some of the suggestions look like it could probably be fine to implement eq, others I was less certain.

It seemed to me that it might be better to just disable that lint, if the things it is suggesting are traits no one is asking for which may hamper future changes.

ltratt commented 1 year ago

I'm fine with not implementing Eq on most of these until/unless we find that we need to.

bors r+

bors[bot] commented 1 year ago

Build succeeded: