search

softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
507 stars 31 forks source link

Update to latest clippy/cargo #414

Closed ratmice closed 1 year ago

ratmice commented 1 year ago

In my previous patches I had neglected to run clippy with --all-targets, so there were some lints triggering in test code. While fixing that I updated rustc/clippy, that triggered some new lints.

As well as a cargo warning:

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

Looking through https://doc.rust-lang.org/cargo/reference/resolver.html#feature-resolver-version-2

I had a vague recollection of the build dependencies overlap with selected features possibly affecting us, so it seemed like it might be worthwhile to bump that.

ltratt commented 1 year ago

bors r+

ltratt commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Already running a review

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.