search

softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
494 stars 32 forks source link

Give better warnings if lexer/grammar can't be read at build time. #459

Closed ltratt closed 1 month ago

ltratt commented 1 month ago

If the user gave an incorrect path, they got an internal unwrap, or similarly unhelpful message, from lrlex and lrpar. This commit tells them what file was attempting to be read, which makes working out what's actually gone wrong much easier.

ltratt commented 1 month ago

@ratmice Feel free to press the "merge" button if the PR works for you -- you have full rights on this repo!

ratmice commented 1 month ago

Thanks, I was just about to ask about how we want to handle that since things have changed a little bit in the review process now that we don't use bors any longer.

ltratt commented 1 month ago

Yeah it's a bit messy, but the "merge" button hands things over to Buildbot, at which point it's the same as the bors days! I mostly miss bors try...