search

softdevteam / grmtools

Rust grammar tool libraries and binaries
Other
517 stars 31 forks source link

docs: Add a chapter on start states to the book #468

Closed ratmice closed 3 months ago

ratmice commented 3 months ago

Despite the fact that I am the terriblest writer, here is a rough draft for a chapter on start states.

I still need to test the code examples and stuff so marking as draft, but would appreciate any feedback.

ltratt commented 3 months ago

This all looks good, and worth merging now. Can you line wrap to the same length as the other md files (I think 100 chars) and force push?

ratmice commented 3 months ago

Will try and do so later today, as well as going through and running all the code snippets.

ratmice commented 3 months ago

Because I made some additional changes (changed the link format so it would fit on 100 char lines), I was hesitant to squash/force push.

I tested all the complete examples containing e.g. those containing %% and fixed the one error I found. Also removed a line that was no longer relevant.

I am happy with this now, and feel like it's ready for a squash.

ltratt commented 3 months ago

LGTM! Please squash.

ratmice commented 3 months ago

Squashed.