softdevteam / lrpar

Rust LR parser
Other
1 stars 0 forks source link

Fix horrible typo and the resulting chaos it caused. #25

Closed ltratt closed 7 years ago

ltratt commented 7 years ago

The test pretty-printer printed both Delete and Shift as Delete, meaning that a whole load of tests were incorrect. The reason that this wasn't caught earlier is that Delete can often make as much sense as Shift (even though one would, obviously, prefer Shift to Delete whenever possible).

ltratt commented 7 years ago

Basically the mistake is on line 333: the rest of the PR just deals with the fallout.

ptersilie commented 7 years ago

Looks ok. Just waiting for the tests before I merge.