search

softdevteam / lrpar

Rust LR parser
Other
1 stars 0 forks source link

KimYi fixes #33

Closed ltratt closed 6 years ago

ltratt commented 6 years ago

A couple of relatively small fixes and updates to the KimYi algorithm. The first commit is part of our extension of KimYi's algorithm; the second and third commits make us more faithfully follow the paper.

ptersilie commented 6 years ago

Ironically the commit talking about redundancy has a redundant word in it: Redundant configurations in the paper are determined solely determined by the parsing stack

ptersilie commented 6 years ago

Two minor comments. Rest looks good.

ltratt commented 6 years ago

OK, I've fixed the commit text, and (hopefully) explained why the other commit isn't a problem. If you're OK with this, I think it can be merged.

ptersilie commented 6 years ago

Does this need any squashing?