search

softdevteam / lrpar

Rust LR parser
Other
1 stars 0 forks source link

Corchuelo cleanup #53

Closed ltratt closed 6 years ago

ltratt commented 6 years ago

This PR contains one very simple and one not-so-simple-but-not-that-complex-either changes to the Corchuelo recoverer.

ltratt commented 6 years ago

Hmm, I missed a warning from rustc: fixing.

ltratt commented 6 years ago

The third commit fixes the warning (TBH, it covers a case that I've never got close to seeing with real grammars, though one can trigger it with artificially tiny examples).

ptersilie commented 6 years ago

Looks good. You want to rebase the last commit or is it okay this way?

ltratt commented 6 years ago

I was just about to squash it before I realised that it actually makes more sense to be separate. So I'd suggest we merge as-is if you're OK with that.

ptersilie commented 6 years ago

I'm ok with that. Merged!