Closed ltratt closed 6 years ago
This is really two useful commits (the first and third) with a cosmetic (the second). First, when we have bucketloads of successful repair sequences (occasionally we can generate hundreds of thousands), our simplification "algorithm" (a bubblesort in disguise) was horribly slow: https://github.com/softdevteam/lrpar/commit/737701bdc1813804f8e19c9f489344b59c90a0ed fixes this. Second, when we have that many repair sequences, ranking them can be quite slow too, so use the timeout for that too: https://github.com/softdevteam/lrpar/commit/48e3628e50165345f8b2fbe988dc3265129f3600 fixes this.
Merged!
ptersilie
commented
6 years ago ptersilie
commented
6 years ago
This is really two useful commits (the first and third) with a cosmetic (the second). First, when we have bucketloads of successful repair sequences (occasionally we can generate hundreds of thousands), our simplification "algorithm" (a bubblesort in disguise) was horribly slow: https://github.com/softdevteam/lrpar/commit/737701bdc1813804f8e19c9f489344b59c90a0ed fixes this. Second, when we have that many repair sequences, ranking them can be quite slow too, so use the timeout for that too: https://github.com/softdevteam/lrpar/commit/48e3628e50165345f8b2fbe988dc3265129f3600 fixes this.