search

softdevteam / mattermost-github-integration

GitHub integration for Mattermost
Other
79 stars 50 forks source link

Update README to explain how to fill the channel #11

Closed remimarenco closed 8 years ago

remimarenco commented 8 years ago

Hi!

I have explained how to fill the channel ID in the config file. Hope it will help people who are going to use this extension!

ptersilie commented 8 years ago

Otherwise looks good. If you fix the stuff I commented we can merge this.

remimarenco commented 8 years ago

I think I did :)

ptersilie commented 8 years ago

Great. Could we also change your_channel_id to repository-channel?

remimarenco commented 8 years ago

Hrmm, I don't agree with this. The issue I ran into is because repochannel leaded me to enter the name of my channel and not its ID.

When looking into Mattermost way of naming this field, it seems to be <channel id> => http://forum.mattermost.org/t/api-get-latest-messages-from-a-channel/1169/2

I think this config sample is here to lead people to fill properly the fields. We should keep this in mind, and that is why I pushed it like this.

I would agree on repository-channel-id if it fits better to your needs.

ptersilie commented 8 years ago

repository-channel-id is perfect. Thanks.

ptersilie commented 8 years ago

Maybe we should squash this down to a single commit and then I'm happy to merge it. :+1:

remimarenco commented 8 years ago

That should do it.

I would suggest not being so picky with your first commiters. A strategy that usually works is to thank people, and change it yourself the way you want. We both spent too much time on this, in my opinion.

ptersilie commented 8 years ago

Thanks. Merged.