softdevteam / mattermost-github-integration

GitHub integration for Mattermost
Other
79 stars 50 forks source link

Run flask not in debug mode #14

Closed mharrend closed 8 years ago

mharrend commented 8 years ago

Due to security reasons Flask should not run in debug mode:

app.run(host='0.0.0.0', port=port, debug=True)

Especially the possibility to execute arbitrary code in case of a failure is quite dangerous, have a look here: http://flask.pocoo.org/docs/0.11/quickstart/#debug-mode

So, I would propose the simple solution to set

debug = False 

by default.

ptersilie commented 8 years ago

Good point. Fixed.