Closed kostecky closed 7 years ago
That's a cool idea. Thanks for the PR! Do you think people would want to edit this on a per-hook basis, or would one setting for all hooks be enough?
For example:
GITHUB_IGNORE_ACTIONS = {
"issues": ["labeled", "close"]
}
Looks a bit cleaner than having it within the MATTERMOST_WEBHOOK_URLS
. But I don't know if that's too restrictive.
That's a good point. I like the flexibility, but to tell you the truth, my use-case matches your suggestion, so I'd be happy with one setting =)
Okay, if this still matches your use case, then let's go with one setting for all repos for now. We can always change it quite easily if anyone needs a more flexible setting.
Do you want to update the PR or shall I do it before I merge?
There we are. Merge at will, unless you want me to squash it and re-pull to eliminate the unnecessary commits?
Great. Thanks a lot. :) We still have to edit the Readme but I will do that before I merge. I'll also squash it down to a single commit then.
Right, my bad. Thanks!
No worries. :)
Alright. Everythin is merged! I also had to change if config.GITHUB_IGNORE_EVENTS:
to hasattr(config, "GITHUB_IGNORE_EVENTS):
in order to not break other users setup who don't have GITHUB_IGNORE_EVENTS
in their config yet.
Would you mind checking if the master branch works for you?
Works! Thanks again!
Github aggregates too many actions under some of their events. You may want to ignore
label
actions under issues, but still see issues get opened. This is an optional element to add to the tuple, so it will work whether you define it or not.