Store number of vars per function in SirFuncCx

[ptersilie]

Requires a rebase after #102 is merged.

[ltratt]

A minor terminology thing: it's fairly common in compilers (and I note that's the case here with mir_body.local_decls) to call these "locals". So maybe num_locals might be a slightly more idiomatic name? [I don't feel strongly about this, but thought it might be worth mentioning.]

[ptersilie]

Good point. Will fix.

[ltratt]

@ptersilie Is this ready for rereview?

[ptersilie]

Whoops, forgot to assign @vext01 to this. But we are currently blocked on the bors issue anyways.

[ltratt]

Well, I'm happy with your change in https://github.com/softdevteam/ykrustc/pull/103/commits/5a24c7f3aca97a088190f349fbc72a67956d5477.

[ltratt]

@ptersilie I think this now needs rebasing against master (and, unfortunately, there are a couple of conflicts), and squashing. Once that's done, I think we can now merge!

[vext01]

I'm late to the party, but the changes LGTM.

[ptersilie]

Had to add one more fix which we'll need to squash later. Though we can do that after we merged https://github.com/softdevteam/yk/pull/65.

[ptersilie]

Should I start the merge process?

[vext01]

Please go ahead.

[ptersilie]

Undid the cycle breaker. Ok to squash?

[vext01]

Please squash.

[ptersilie]

Squashed.

[vext01]

bors r+

[bors[bot]]

Build failed:

• buildbot/ykrustc-buildbot-build-script-hwt

[vext01]

  failed to authenticate when downloading repository
attempted to find username/password via git's `credential.helper` support, but failed

Is this a lock file issue?

[ptersilie]

Whoops, forgot to push that. Let's try.

bors try

[bors[bot]]

try

Build succeeded:

• buildbot/ykrustc-buildbot-build-script-hwt

[vext01]

Please squash.

[vext01]

bors r+

[ptersilie]

Squashed.

[bors[bot]]

Build succeeded:

• buildbot/ykrustc-buildbot-build-script-hwt