search

softdevteam / ykrustc

Yorick Meta-tracer
Other
6 stars 4 forks source link

[2/3] Remove the software tracer and move trace_inputs to yktrace #121

Closed bjorn3 closed 4 years ago

bjorn3 commented 4 years ago

Depends on https://github.com/softdevteam/yk/pull/100

vext01 commented 4 years ago

There are some ignored tests which can also probably go.

Search for swt_ignore

bjorn3 commented 4 years ago

Should I also remove all #![no_sw_trace] attributes from tests?

vext01 commented 4 years ago

I think so. Since software tracing will be dealt with by cranelift, right?

vext01 commented 4 years ago

I think this is ready to go then? Probably without the need for a cycle breaker?

bjorn3 commented 4 years ago

Yes, or do you want me to squash de5bfe8 and 76ba1f9?

ltratt commented 4 years ago

@bjorn3 Our approach to squashing is that, in general, the person who raised the PR decides if/what needs squashing. So, normally, it's up to you!

bjorn3 commented 4 years ago

Ok, I have squashed those commits.

vext01 commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded: