softdevteam / ykrustc

Yorick Meta-tracer
Other
6 stars 4 forks source link

Remove our sole in-compiler SIR test. #122

Closed vext01 closed 4 years ago

vext01 commented 4 years ago

Since we are having a cleanup of ykrustc, this has been bugging me for some time. See commit message.

vext01 commented 4 years ago

Are you able to run bors? I may need to fiddle some settings if not.

bjorn3 commented 4 years ago

I am pretty sure bors will not accept me, but I can try:

bors r+

bors[bot] commented 4 years ago

:lock: Permission denied

Existing reviewers: click here to make bjorn3 a reviewer

vext01 commented 4 years ago

Try now.

bjorn3 commented 4 years ago

bors r+

bjorn3 commented 4 years ago

It works. Thanks!

vext01 commented 4 years ago

I had to grant you the "write" role to the repo to allow bors.

bors[bot] commented 4 years ago

Build failed:

vext01 commented 4 years ago

Missed some stuff. Fixing.

vext01 commented 4 years ago

OK to squash?

bjorn3 commented 4 years ago

Sure

vext01 commented 4 years ago

splat.

bjorn3 commented 4 years ago

I confirmed that this makes the diff of compiletest against upstream empty.

bors r+

vext01 commented 4 years ago

I confirmed that this makes the diff of compiletest against upstream empty.

I also did that :)

bors[bot] commented 4 years ago

Build succeeded: