softdevteam / ykrustc

Yorick Meta-tracer
Other
6 stars 4 forks source link

crate_hash -> cgu_hash and don't hash the crate hash. #127

Closed vext01 closed 4 years ago

vext01 commented 4 years ago

The crate hash changes frequently (with every source code change), so we shouldn't use it in the CGU hash.

There is a companion commit coming for this and we will need to do a cycle breaker.

Companion: https://github.com/softdevteam/yk/pull/113

bjorn3 commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build failed:

vext01 commented 4 years ago

That'll fail due to the path override. Once we've reviewed both PRs, I'll add a cycle breaker.

vext01 commented 4 years ago

Cycle breaker in place.

bors try

bors[bot] commented 4 years ago

try

Build succeeded:

bjorn3 commented 4 years ago

softdevteam/yk#113 has been merged.

vext01 commented 4 years ago

Removed cycle breaker and updated lock in a force push.

bjorn3 commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded: