Patch the yk dep using a special line in the PR description.

[vext01]

I got this working towards the end of last week. I think we can start the review now.

When doing a ykrustc pull request (PR), if the PR description contains a lineci-yk: <github-user> <branch> then the Cargo.toml file is (temporarily) patched to override the dependency.

Once a ykrustc PR is merged, the yk branch should be merged immediately after. We can't do that automatically unfortunately.

Testing

I'll test this now by overriding the yk dependency to a branch I've deliberately broken.

ci-yk: vext01 broken-branch

[vext01]

bors try

[ltratt]

Apart from that one comment, this looks good to me!

[vext01]

bors try-

[vext01]

bors try

[vext01]

My apologies. The line should be ci-yk not yk-ci. I can see from the CI log that it didn't patch.

bors try-

[vext01]

Fixed description. Let's try again.

bors try

[vext01]

There we go:

+ /opt/buildbot/bin/python3 .buildbot_patch_yk_dep.py
Patching yk dependency to: https://github.com/vext01/yk broken-branch

[bors[bot]]

try

Build failed:

• buildbot/ykrustc-buildbot-build-script-hwt

[vext01]

error: expected one of `(`, `[`, or `{`, found keyword `pub`
  --> /home/buildbot-worker3/.cargo/git/checkouts/yk-d2e2b9740fea6468/f581721/ykpack/src/types.rs:13:1
   |
10 | CARNAGE!
   |         - expected one of `(`, `[`, or `{`

Good!

Now, I haven't tested r+ and the commit message format is slightly different. Let's leave the override in and attempt a merge. It should fail.

Please do a r+.

[ltratt]

bors r+

[bors[bot]]

Build failed:

• buildbot/ykrustc-buildbot-build-script-hwt

[vext01]

Good. Now I've removed the line, if you r+ again, it should merge ok.

[ltratt]

bors r+

[vext01]

Looking good. It doesn't appear to have patched any deps.

[bors[bot]]

Build succeeded:

• buildbot/ykrustc-buildbot-build-script-hwt