softdevteam / yksom

Other
8 stars 6 forks source link

Reorganise functions #183

Closed ltratt closed 4 years ago

ltratt commented 4 years ago

This PR aims to sort out the internal representation of SOM functions. The basic problem is that we previously had quite separate representations of SOM methods and blocks, and that hinders o. The major work is done in https://github.com/softdevteam/yksom/commit/9cbe414650907d79366d4f30db6c7486d8148f0e (https://github.com/softdevteam/yksom/commit/cb5b342d35032008ac332d8c7c0c967a5075459d is a simple stand-alone improvement).

ptersilie commented 4 years ago

Just some possible typos in the first commit message:

causing an internal awkward API

extra internal here?

and open up future optimisation

s/open/opens

track all a function's blocks

s/all/all of

ltratt commented 4 years ago

OK for me to force push?

ptersilie commented 4 years ago

Please do.

ltratt commented 4 years ago

Force pushed.

ptersilie commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded: