softdevteam / yksom

Other
8 stars 6 forks source link

Test rustc_boehm integration as part of bors #189

Closed jacob-hughes closed 4 years ago

jacob-hughes commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build failed:

jacob-hughes commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build failed:

jacob-hughes commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build failed:

jacob-hughes commented 4 years ago

bors try

bors[bot] commented 4 years ago

try

Build succeeded:

ltratt commented 4 years ago

Is this ready for review or ...?

jacob-hughes commented 4 years ago

Yes sorry I forgot to comment on the this.

ltratt commented 4 years ago

Will we cache rustc_boehm anywhere, or is that a bit difficult to set up?

jacob-hughes commented 4 years ago

No. That would be ideal but I'm not sure how we could set this up. I suppose we could build a new rustc_boehm bin each time a PR lands on that repo, but it would be a bit fiddly I think.

ltratt commented 4 years ago

Please squash.

jacob-hughes commented 4 years ago

Squashed

ltratt commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build failed:

jacob-hughes commented 4 years ago

This should be merge-able again once https://github.com/softdevteam/rboehm/pull/26 has landed.

ltratt commented 4 years ago

bors r+

bors[bot] commented 4 years ago

Build succeeded: