Closed ltratt closed 3 years ago
This LGTM. Just a minor comment as the name of the allocator in libgc
has changed to remove explicit references to Boehm from the API. Once https://github.com/softdevteam/libgc/pull/38 lands, this should compile.
bors try
@jacob-hughes I'm not sure if this still waiting on another PR, or whether I need to change something in here or not. Any pointers?
Can you force-push a change where this is rebased against the latest libgc master? I think it should work then.
I'm not sure I know what you mean -- are you suggesting rebasing against another repo?
Argh, I'm an idiot. this is a yksom PR. Sorry I got confused. Hmm, ok, so libgc should be up to date now. Let me try building it locally and see what's going on.
OK this now works locally for me. Let's check it works on bors/buildbot!
bors try
I think that just needs rustfmt'ing :crossed_fingers:
bors try
bors try
bors try
There's a typo in the buildbot script, it should be rustgc
instead of rustcgc
.
bors try
:tada: Please squash
Squashed.
bors r+
Build succeeded:
Hi, does this currently work with externally available versions?
I get the following issue:
error: failed to select a version for `libgc`.
... required by package `yksom v0.1.0
versions that meet the requirements `*` are: 0.1.0
the package `yksom` depends on `libgc`, with features: `rustgc` but `libgc` does not have these features.
The relevant Rust versions seem to be:
$ rustc --version
rustc 1.53.0-nightly (361bfce30 2021-04-07)
$ rustup --version
rustup 1.23.1 (3df2264a9 2020-11-30)
$ cargo --version
cargo 1.53.0-nightly (65d57e6f3 2021-04-04)
For more details see:
https://travis-ci.com/github/SOM-st/SOM/jobs/496945019#L254-L258
yksom is currently broken because of the GC: @jacob-hughes is hopefully unbreaking it soon!
Ok, thanks.
This PR tries to move yksom from
rboehm
tolibgc
. However it fails to compile with:I wonder if this is because
libgc
should be using#[global_allocator]
or similar?