Closed ltratt closed 10 months ago
I think the two commits should be separate.
@vext01 This one should be ready to re-review and merge.
I think @ltratt is better qualified for yksom changes.
Sure, but I think you'll need to do the final sign off because Laurie opened the PR.
Yes, @vext01 you need to review this please.
Please squash.
Squashed
Ok so when https://github.com/softdevteam/alloy/pull/101 lands, this should be merge-able :)
sorry, i didn't see it had failed.
It's a rustfmt problem. I've fixed it here: 9aa838, let me know if I can squash.
Go ahead.
Squashed
Did you forget to sign the commit?
Weird! My gpg-agent has failed. Can I force-push an update?
Please push a signed commit.
Force-pushed a signed commit.
Ugh I’ve not seen that one before.
16:41:47 thread 'main' panicked at src/lib/vm/core.rs:404:13:
16:41:47 Not enough stack space to execute block.
ouch.
Any news on this one?
That's one for @jacob-hughes.
@vext01 You should be able to merge this one now :)
Any squashing to be done?