softdevteam / yksom

Other
8 stars 6 forks source link

Move to GitHub merge queues. #228

Closed ltratt closed 10 months ago

vext01 commented 1 year ago

Any squashing to be done?

ltratt commented 1 year ago

I think the two commits should be separate.

jacob-hughes commented 1 year ago

@vext01 This one should be ready to re-review and merge.

vext01 commented 1 year ago

I think @ltratt is better qualified for yksom changes.

jacob-hughes commented 1 year ago

Sure, but I think you'll need to do the final sign off because Laurie opened the PR.

ltratt commented 1 year ago

Yes, @vext01 you need to review this please.

vext01 commented 1 year ago

Please squash.

jacob-hughes commented 1 year ago

Squashed

jacob-hughes commented 1 year ago

Ok so when https://github.com/softdevteam/alloy/pull/101 lands, this should be merge-able :)

vext01 commented 1 year ago

sorry, i didn't see it had failed.

jacob-hughes commented 1 year ago

It's a rustfmt problem. I've fixed it here: 9aa838, let me know if I can squash.

vext01 commented 1 year ago

Go ahead.

jacob-hughes commented 1 year ago

Squashed

vext01 commented 1 year ago

Did you forget to sign the commit?

jacob-hughes commented 1 year ago

Weird! My gpg-agent has failed. Can I force-push an update?

vext01 commented 1 year ago

Please push a signed commit.

jacob-hughes commented 1 year ago

Force-pushed a signed commit.

jacob-hughes commented 1 year ago

Ugh I’ve not seen that one before.

vext01 commented 1 year ago
16:41:47 thread 'main' panicked at src/lib/vm/core.rs:404:13:
16:41:47 Not enough stack space to execute block.

ouch.

vext01 commented 11 months ago

Any news on this one?

ltratt commented 11 months ago

That's one for @jacob-hughes.

jacob-hughes commented 10 months ago

@vext01 You should be able to merge this one now :)