Closed n1gp closed 2 years ago
Hi Rick, I completed your pull request. For the override of receiver_nco.v, I usually just read in the standard set of files, but then read in receiver_ciconly.v at a time after that. The last definition will be used. See hermeslite.qsf in gateware/variants/hl2b5up_cicrx
73, Steve kf7o
On Wed, Feb 2, 2022 at 1:39 PM Rick Koch @.***> wrote:
Steve, I pulled in the file.tcl from ../../boards/radioberry-juice/files.tcl because it had conflicts with set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v verses set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_ciconly.v
Maybe there is a better way to override receiver_nco.v ?
You can view, comment on, or merge this pull request online at:
https://github.com/softerhardware/Hermes-Lite2/pull/165 Commit Summary
- deedd09 https://github.com/softerhardware/Hermes-Lite2/pull/165/commits/deedd096e49ea74ab160b3b1bb4c3813642be31a Adding cicrx for Radioberry juice variants.
File Changes
(12 files https://github.com/softerhardware/Hermes-Lite2/pull/165/files)
- A gateware/variants/radioberry_juice_cl016_cicrx/.gitignore https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-40b935f0a81eefd74781cfa36a74e795f28116fe48e87d1bfa9b3ecedc7cf917 (11)
- A gateware/variants/radioberry_juice_cl016_cicrx/Makefile https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-dc6874f18379bb3de67da63ceac09d8e07d360cd245753f0273a3f94acbeffb7 (15)
- A gateware/variants/radioberry_juice_cl016_cicrx/files.tcl https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-c5e9537a20c13af7151bc53d7353843243d2761f9080e2e5f8ab4feadfd528f3 (91)
- A gateware/variants/radioberry_juice_cl016_cicrx/radioberry.qpf https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-ec84d184952e5f728e619359d89b561906dc01d83379dd1a151467f8e2ba9f34 (31)
- A gateware/variants/radioberry_juice_cl016_cicrx/radioberry.qsf https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-670c1990e45abb42503f4b870752373f3200afe6386df49712e7b58dc7eca6a2 (62)
- A gateware/variants/radioberry_juice_cl016_cicrx/radioberry.v https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-879b9695e535e39b72d77e2c82e9c15edfc575c5e495febae48d15b242f4d858 (91)
- A gateware/variants/radioberry_juice_cl025_cicrx/.gitignore https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-8be5e623ab68f30a0c5511242bd800d3d035c2c02f09e71e161bbfca9aefe3b0 (11)
- A gateware/variants/radioberry_juice_cl025_cicrx/Makefile https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-3f5b1f7e93f1a7e87094f152da68583fb1d00028eb3ffa1cd6505916136ef056 (15)
- A gateware/variants/radioberry_juice_cl025_cicrx/files.tcl https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-0e545cf740698182691fe96ce51367fa28d0ce1b79bbc6dff5de38138d3c7c6c (92)
- A gateware/variants/radioberry_juice_cl025_cicrx/radioberry.qpf https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-5aebdca24a5a131dd9b57d0302389351547b5cc5e0fae6d0bb12e9f3e417943c (31)
- A gateware/variants/radioberry_juice_cl025_cicrx/radioberry.qsf https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-83548462f86e4bc62fd749e18b69dcfa4c309107fb34a830114e0a34050f7e94 (69)
- A gateware/variants/radioberry_juice_cl025_cicrx/radioberry.v https://github.com/softerhardware/Hermes-Lite2/pull/165/files#diff-edf101b24c0758859289e4f15efc22a2e74a66da0519abec2da8ef4aa36f1079 (91)
Patch Links:
- https://github.com/softerhardware/Hermes-Lite2/pull/165.patch
- https://github.com/softerhardware/Hermes-Lite2/pull/165.diff
— Reply to this email directly, view it on GitHub https://github.com/softerhardware/Hermes-Lite2/pull/165, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO4THMZ7Z6KQBQTWYZUC5DUZGQBXANCNFSM5NNGVQNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Steve,
I did look at hl2b5up_cicrx/hermeslite.qsf and tried to do the same, but its not working. I think it works for HL2 because boards/hl2b5up/files.tcl doesn't have
set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v
There is no conflict for receiver_ciconly.v, but boards/radioberry-juice/files.tcl does have receiver_nco.v
Not a big deal, but I was worried that down the road it may cause headaches when updating files.
Error (10228): Verilog HDL error at receiver_ciconly.v(205): module "receiver_nco" cannot be declared more than once File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_ciconly.v Line: 205 Info (10499): HDL info at receiver_nco.v(32): see declaration for object "receiver_nco" File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_nco.v Line: 32 Info (12021): Found 0 design units, including 0 entities, in source file /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_ciconly.v Info (12021): Found 1 design units, including 1 entities, in source file radioberry.v Info (12023): Found entity 1: radioberry File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/variants/radioberry_juice_cl016_cicrx/radioberry.v Line: 8 Info (144001): Generated suppressed messages file /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/variants/radioberry_juice_cl016_cicrx/build/radioberry.map.smsg Error: Quartus Prime Analysis & Synthesis was unsuccessful. 1 error, 0 warnings
I see how to fix this after looking at Johan's commit 13b67d73c6a64e950493fadf79683d042093ab06
I'll send another PR soon...
Steve, I pulled in the file.tcl from ../../boards/radioberry-juice/files.tcl because it had conflicts with set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v verses set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_ciconly.v
Maybe there is a better way to override receiver_nco.v ?