softerhardware / Hermes-Lite2

A second generation low-cost amateur HF software defined radio transceiver.
http://www.hermeslite.com
227 stars 80 forks source link

Adding cicrx for Radioberry juice variants. #165

Closed n1gp closed 2 years ago

n1gp commented 2 years ago

Steve, I pulled in the file.tcl from ../../boards/radioberry-juice/files.tcl because it had conflicts with set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v verses set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_ciconly.v

Maybe there is a better way to override receiver_nco.v ?

softerhardware commented 2 years ago

Hi Rick, I completed your pull request. For the override of receiver_nco.v, I usually just read in the standard set of files, but then read in receiver_ciconly.v at a time after that. The last definition will be used. See hermeslite.qsf in gateware/variants/hl2b5up_cicrx

73, Steve kf7o

On Wed, Feb 2, 2022 at 1:39 PM Rick Koch @.***> wrote:

Steve, I pulled in the file.tcl from ../../boards/radioberry-juice/files.tcl because it had conflicts with set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v verses set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_ciconly.v

Maybe there is a better way to override receiver_nco.v ?

You can view, comment on, or merge this pull request online at:

https://github.com/softerhardware/Hermes-Lite2/pull/165 Commit Summary

File Changes

(12 files https://github.com/softerhardware/Hermes-Lite2/pull/165/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/softerhardware/Hermes-Lite2/pull/165, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO4THMZ7Z6KQBQTWYZUC5DUZGQBXANCNFSM5NNGVQNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

n1gp commented 2 years ago

Steve,

I did look at hl2b5up_cicrx/hermeslite.qsf and tried to do the same, but its not working. I think it works for HL2 because boards/hl2b5up/files.tcl doesn't have

set_global_assignment -name VERILOG_FILE ../../rtl/radio_openhpsdr1/receiver_nco.v

There is no conflict for receiver_ciconly.v, but boards/radioberry-juice/files.tcl does have receiver_nco.v

Not a big deal, but I was worried that down the road it may cause headaches when updating files.

Error (10228): Verilog HDL error at receiver_ciconly.v(205): module "receiver_nco" cannot be declared more than once File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_ciconly.v Line: 205 Info (10499): HDL info at receiver_nco.v(32): see declaration for object "receiver_nco" File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_nco.v Line: 32 Info (12021): Found 0 design units, including 0 entities, in source file /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/rtl/radio_openhpsdr1/receiver_ciconly.v Info (12021): Found 1 design units, including 1 entities, in source file radioberry.v Info (12023): Found entity 1: radioberry File: /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/variants/radioberry_juice_cl016_cicrx/radioberry.v Line: 8 Info (144001): Generated suppressed messages file /home/mh/Desktop/SDR/HPSDR/LATEST/Hermes-Lite2/gateware/variants/radioberry_juice_cl016_cicrx/build/radioberry.map.smsg Error: Quartus Prime Analysis & Synthesis was unsuccessful. 1 error, 0 warnings

n1gp commented 2 years ago

I see how to fix this after looking at Johan's commit 13b67d73c6a64e950493fadf79683d042093ab06

I'll send another PR soon...