gokulnair2001 commented 3 years ago

So while using your pod I felt it was quiet amazing but the feature it was lacking behind was in terms of UX(User experience), To solve this I thought why not add an UX enhancing feature called "Haptic Feedback".

Added a Haptic Feedback generator code in the SHCircleBar.swift file and a method to call it in SHCircleBarController.swift.

This merge will not create any merge conflict as well as issue in your Pod, it will only enhance the user experience. Personally being a Developer I felt this feature was quite required in your app.

New Changes: From now if the user clicks on any tab bar item they will get a feedback from the phone.

If any changes required, please inform me.

gokulnair2001 commented 3 years ago

Also, I saw that you added a new singleton (not really a singleton, since it has it's init() public) for the haptic feedback which is not used and also does not belong in any Xcode project (pod or example), it is just added to the root of the folder. Please delete that file if it is not used.

Hey Adrian, Actually I didn't understood what you have mentioned above, I didn't added any file, if possible will you elaborate or add a screen shot of it.

And about the Haptic Feedback change I will surely change it and add an option for the user :)

gokulnair2001 commented 3 years ago

Required Changes done

So as you told I have added @IBInspactable to the code, so that now the user have the option to add haptic feed back, please check my implementation and let me know is there any correction required.
Still if any changes required, do tell me :).
And about my second commit regarding the UI changes, you didn't mentioned anything about it.

gokulnair2001 commented 3 years ago

Thanks for your interest on helping this repository. Adding haptic feedback is a great idea! Since this is an open project, everyone who uses CircleBar, might not want to use haptic feedback in their apps, thus forcing it and not letting a decision on their side is not the best solution. Please add a boolean that is @IBInspactable to SHCircleBar, so that it would be easy for others to choose their preference. Also, I saw that you added a new singleton (not really a singleton, since it has it's init() public) for the haptic feedback which is not used and also does not belong in any Xcode project (pod or example), it is just added to the root of the folder. Please delete that file if it is not used. Thank you again for your contribution 😄

I understood what you have mentioned regarding the file at root, actually at first I thought to create a new file, then realised why to create a new one, so after my second commit I have removed it, once you can clone my forked project to get an exact idea :).

The new file as shown in changes are not present now, you can see in my future commit changes.

perteadrian commented 3 years ago

Hey, here's the screenshot showing that the folder has a new added file:

gokulnair2001 commented 3 years ago

Will change this, sorry for the inconvenience caused!

On Mon, Feb 8, 2021 at 8:05 PM Adrian Perte notifications@github.com wrote:

@perteadrian commented on this pull request.

In CircleBar/Classes/SHCircleBar.swift https://github.com/softhausHQ/CircleBar/pull/24#discussion_r572094118:

@@ -23,6 +23,12 @@ import UIKit customInit() }

@IBInspectable var HapticFeedback:Bool = false {

variable are lowered camel cased, please change this to hapticFeedback

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/softhausHQ/CircleBar/pull/24#pullrequestreview-585561258, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANNFOY3EL7O6XR2NFLC63UDS57ZD3ANCNFSM4W6OCH5A .

gokulnair2001 commented 3 years ago

I got the file, sorry for the inconvenience! Highly apologies!

On Mon, Feb 8, 2021 at 8:18 PM Gokul Nair gokulnair.2001@gmail.com wrote:

I guess it's showing for the first commit , because later I removed it. Even though I tried finding it in the Xcode project it's not present. Please check later commit changes !

On Mon, Feb 8, 2021 at 8:03 PM Adrian Perte notifications@github.com wrote:

Hey, here's the screenshot showing that the folder has a new added file: [image: Screenshot 2021-02-08 at 16 31 51] https://user-images.githubusercontent.com/15149863/107233484-53fa9080-6a2b-11eb-88e4-9fb1c32d4fad.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/softhausHQ/CircleBar/pull/24#issuecomment-775191702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANNFOY2JOPWEMKECYCGFL4DS57Y4VANCNFSM4W6OCH5A .

gokulnair2001 commented 3 years ago

Final Changes

All the changes are done according to your standards , please do check and tell me if any further changes required.
The feature is working all fine.
Thank you for the immense help.

gokulnair2001 commented 3 years ago

@perteadrian I had made all changes as required, do have a look on it!

perteadrian commented 3 years ago

@gokulnair2001, thanks again for your interest in this library. Everything looks good so far. We will merge this when we release a new version on cocoapods also (~next week) :)

gokulnair2001 commented 3 years ago

Thank you so much for your constant support, though my contribution was small but I learned a lot in this journey.

Thank you @perteadrian @perteraul 😊

softhausHQ / CircleBar

Added Haptic Feedback : Enhance User Experience #24

Required Changes done

@perteadrian commented on this pull request.

Final Changes