softlayer / jumpgate

A simple library to make more clouds compatible with OpenStack.
http://softlayer.github.io/jumpgate/
MIT License
46 stars 29 forks source link

Correct http return code of identify versions api #147

Closed zhiyanliu closed 10 years ago

zhiyanliu commented 10 years ago

Keystone returns 300 http code (Multiple Choices) instead of 200 (OK) [0] when client GETs the api version info that current identify service supported.

This wrong return code causes keystonemiddleware failed at api version query [1] with error "Unable to get version info from keystone: 200", which middleware as a client of keystone lives in a upperlayer service.

[0] https://github.com/openstack/keystone/blob/master/keystone/controllers.py#L132 [1] https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token.py#L1245

For the details of curl test, see http://paste.openstack.org/show/92177/ .

Signed-off-by: Zhi Yan Liu zhiyanl@cn.ibm.com

zhiyanliu commented 10 years ago

A pull-request for a patch to correct http return code of identify versions api .

jimlindeman commented 10 years ago

+1 Nice simple change

zhiyanliu commented 10 years ago

Cool, thanks.