softlayer / knife-softlayer

Other
25 stars 21 forks source link

New user_data option when creating instance #40

Closed iankendrick closed 8 years ago

iankendrick commented 8 years ago

Allow user to provide user_data as a bootstrap option. Some of our images require user_data for their first boot sequence.

I'm an IBM employee (Aspera, iank@us.ibm.com) so I'm not sure where that puts me on the CLA front. Let me know.

cphrmky commented 8 years ago

@iankendrick ,

Thanks for the PR, I'll check it out today.

RE:

I'm an IBM employee (Aspera, iank@us.ibm.com) so I'm not sure where that puts me on the CLA front.

I believe that means you can contribute without any further nonsense as far as IBM is concerned. If you're truly concerned about it, I suppose ping your first-line manager saying that you're contributing and get him/her to give you an "okay" email.

cphrmky commented 8 years ago

@iankendrick ,

Could you put in a brief example of how to use this into examples/server.md?

Maybe just add a --user-data line onto the section that shows specifying options from a JSON file showing it being used?

iankendrick commented 8 years ago

Maybe just add a --user-data line onto the section that shows specifying options from a JSON file showing it being used?

Updated with example usage in server.md. Let me know if you'd prefer a rebase into a single commit.

I believe that means you can contribute without any further nonsense as far as IBM is concerned. If you're truly concerned about it, I suppose ping your first-line manager saying that you're contributing and get him/her to give you an "okay" email.

Thanks, I just wanted to confirm you guys didn't need anything extra.

cphrmky commented 8 years ago

awesome, thx @iankendrick

can skip the squashing rebase, this project isn't so busy that it makes much difference