search

softlayer / sl-ember-components

An Ember CLI Addon that provides a variety of UI components.
http://softlayer.github.io/sl-ember-components
MIT License
114 stars 27 forks source link

Unit | Component | sl tab panel: setActiveTab() does so correctly #1636

Closed erangeles closed 8 years ago

erangeles commented 8 years ago

@notmessenger setActiveTab() is a dead method left over from jeff's revision, @juwara0 agreed to remove it from the codebase.

Review on Reviewable

juwara0 commented 8 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

notmessenger commented 8 years ago

Reviewed 2 of 2 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io