softlayer / sl-ember-components

An Ember CLI Addon that provides a variety of UI components.
http://softlayer.github.io/sl-ember-components
MIT License
114 stars 27 forks source link

Unit | Component | sl tab panel: getActiveTabName returns the correct value after setActiveTab() is called #1637

Closed erangeles closed 8 years ago

erangeles commented 8 years ago

Review on Reviewable

erangeles commented 8 years ago

@notmessenger same thing here, dead method left over from refactor.

juwara0 commented 8 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

notmessenger commented 8 years ago

Is it expected for the tests in the build to be failing?


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

notmessenger commented 8 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io