search

softlayer / sl-ember-components

An Ember CLI Addon that provides a variety of UI components.
http://softlayer.github.io/sl-ember-components
MIT License
114 stars 27 forks source link

Unit | Component | sl grid: handleListContentScroll() requests data as expected #1642 #1650

Closed erangeles closed 8 years ago

erangeles commented 8 years ago

This change is Review on Reviewable

erangeles commented 8 years ago

adding doc changes as .list-pane no longer exists.

notmessenger commented 8 years ago

@erangeles Does your comment of "adding doc changes as .list-pane no longer exists." mean there are more commits to come against this PR?

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

erangeles commented 8 years ago

There is multiple usages of .list-panein the grid component code that I'm trying to figure out.

erangeles commented 8 years ago

https://github.com/softlayer/sl-ember-components/commit/e00b5b8adf752cf88e860fd1123f3b3b9b569168#diff-ab79330a94d580c0b784c829a359a02b the changeset that removed list-pane. I removed the references of that class in the doc's to simply "table". I think that's the most "truthful" representation of what we are trying to convey.

notmessenger commented 8 years ago

Can you merge the latest branch changes?

Tentatively it looks like the failing test is now passing, but nothing about this PR would have caused that. This test is failing in your other PR, for example - https://github.com/softlayer/sl-ember-components/pull/1639

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

erangeles commented 8 years ago

ready to merge.