search

softlayer / sl-ember-components

An Ember CLI Addon that provides a variety of UI components.
http://softlayer.github.io/sl-ember-components
MIT License
114 stars 27 forks source link

Troubleshoot/refactor listener issues #427

Open notmessenger opened 9 years ago

notmessenger commented 9 years ago

This change was introduced in order to resolve failing tests @joshforisha was encountering at /tests:

https://github.com/softlayer/sl-ember-components/blob/71ae7ee739b7f9b2d20780c6b166da781ef3857b/addon/components/sl-date-range-picker.js#L104

This is not a change that should have had to have been implemented though so any of the following things may be the cause:

This issue's work will dovetails with https://github.com/softlayer/sl-ember-components/issues/426

alxyuu commented 9 years ago

Just removed that line since it was not needed. Tests still pass.

notmessenger commented 9 years ago

https://github.com/softlayer/sl-ember-components/pull/435 intersects this same file/line

SpikedKira commented 8 years ago

1458 will likely close this issue as there is no longer a reliance on jquery event binding.