softlayer / sl-ember-components

An Ember CLI Addon that provides a variety of UI components.
http://softlayer.github.io/sl-ember-components
MIT License
114 stars 27 forks source link

sl-date-range-picker: "endDateValue" should not be able to be set that exceeds "maxDate" #871

Open juwara0 opened 8 years ago

juwara0 commented 8 years ago

Provide a fix for "endDateValue" being able to be set that exceeds "maxDate" and then verify the fix byt turning the skipped test below back on.

This test fails:

test( '"endDateValue" cannot be more than "maxDate"', function( assert ) {

this.render( hbs`
    {{sl-date-range-picker
        maxDate="09/25/2015"
        endDateValue="09/28/2015"
    }}
` );

assert.strictEqual(
    this.$( '>:first-child' ).find( '.sl-daterange-end-date' ).find( 'input' ).val(),
    '09/25/2015',
    'The "endDateValue" is not more than the "maxDate"'
);

});

Yogeswar commented 8 years ago

I'm working on this. addressed by #870 (will cause merge conflicts otherwise)

SpikedKira commented 8 years ago

Should be resolved by #1458