search

softlayer / sl-ember-translate

An Ember CLI Addon that provides the ability to lookup a dictionary value either through method calls or via a component in your templates.
http://softlayer.github.io/sl-ember-translate/
MIT License
4 stars 4 forks source link

Refactor /tests/unit/components/sl-translate-test.js (and likely /addon/components/sl-translate.js) #124

Closed notmessenger closed 9 years ago

notmessenger commented 9 years ago

Should not have to passing parameters to this.subject() that contain the text "Binding" just to test the logic trying to test. This value on the key is happening when Ember binds a parameter to a value via templating syntax but by passing it in it isn't a thorough enough test.

erangeles commented 9 years ago

@notmessenger is this still an issue? It appears to be invalid as the postfix requirement of "binding" and its traces has been removed in both the tests and components in https://github.com/softlayer/sl-ember-translate/pull/200

notmessenger commented 9 years ago

@erangeles agreed