search

softlayer / sl-ember-translate

An Ember CLI Addon that provides the ability to lookup a dictionary value either through method calls or via a component in your templates.
http://softlayer.github.io/sl-ember-translate/
MIT License
4 stars 4 forks source link

Ember.EnumberableUtils.map is deprecated, please refactor to use Array.prototype.map #130

Closed notmessenger closed 9 years ago

notmessenger commented 9 years ago

https://github.com/softlayer/sl-ember-translate/blob/bbdc781cec0729a4d4396ccaeb88a8401573f579/addon/components/sl-translate.js#L113 and https://github.com/softlayer/sl-ember-translate/blob/b54d33a5ab77fd603ad2f19c136dd33184424341/addon/services/translate.js#L148 may be affected by this

Once Ember 1.13 is used by this addon

notmessenger commented 9 years ago

Work this against the EmberCLI-1.13.6 branch.

jonathandavidson commented 9 years ago

Working on this.

jonathandavidson commented 9 years ago

@notmessenger - None of the methods being deprecated in https://github.com/machty/ember.js/commit/909441d1b9508c68623d17002f069b10d1463edb are being used in this library and the examples you listed at this time are using arrays and not Ember.Enumerables. I'm thinking this issue can be closed.