search

softlayer / sl-ember-translate

An Ember CLI Addon that provides the ability to lookup a dictionary value either through method calls or via a component in your templates.
http://softlayer.github.io/sl-ember-translate/
MIT License
4 stars 4 forks source link

Ember.typeOf( Symbol ) returns "function", which will cause problems in this code #146

Closed notmessenger closed 9 years ago

notmessenger commented 9 years ago

https://github.com/softlayer/sl-ember-translate/blob/67e046f0b255f2c538d57bd86f90f91efb4a758e/addon/services/sl-translate.js#L49

https://github.com/emberjs/ember.js/issues/11673 has been opened regarding this issue in Ember.js so depending on the timing of when the issue is worked on it might already be resolved or we will need to accommodate it via a workaround in our code via using typeof. If we do the latter then we need to create an issue to remove our workaround once https://github.com/emberjs/ember.js/issues/11673 is resolved and released.

notmessenger commented 9 years ago

https://github.com/emberjs/ember.js/issues/11673 is not going to be resolved at this time so calls to Ember.typeOf() that are compared to 'object' must also contain logic similar to && 'symbol' != typeof

notmessenger commented 9 years ago

Will need to use jshint ignore entries like in https://github.com/softlayer/sl-ember-components/blob/688911c66d7a678fab6ff935b332d76593b5b400/addon/components/sl-chart.js#L95