search

softlayer / sl-ember-translate

An Ember CLI Addon that provides the ability to lookup a dictionary value either through method calls or via a component in your templates.
http://softlayer.github.io/sl-ember-translate/
MIT License
4 stars 4 forks source link

Closes softlayer/sl-ember-translate#188 #213

Closed notmessenger closed 9 years ago

notmessenger commented 9 years ago

Review on Reviewable

juwara0 commented 9 years ago

I am reviewing this.

Comments from the review on Reviewable.io

juwara0 commented 9 years ago

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

tests/unit/services/sl-translate-test.js, line 18 [r1] (raw file): Where is the container property? I have opened an issue to remove this assertion: https://github.com/softlayer/sl-ember-translate/issues/215

Comments from the review on Reviewable.io

juwara0 commented 9 years ago

I have finished reviewing this and it is ready for merging.

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from the review on Reviewable.io

notmessenger commented 9 years ago

Reviewed 1 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io