search

softlayer / softlayer-object-storage-php

SoftLayer Object Storage PHP Client
Other
28 stars 18 forks source link

Add "connect_timeout" option for cURL. #29

Closed theage closed 9 years ago

theage commented 9 years ago

Add connect_timeout option. However, this currently affects cURL only.

Zend's HTTP client apparently only has a connect timeout, not a timeout for an established link or the entire request, so using connect_timeout would actually be more applicable than the existing timeout option, but this is a semantic change, though not necessarily backwards-incompatible (we could prefer connect_timeout if it is not NULL and fall back to timeout otherwise).

PHP's fsockopen()'s $timeout parameter also refers to a connection timeout rather than a request timeout, which can be specified with stream_set_timeout.

briancline commented 9 years ago

Sorry this took a while, apparently my email notifications aren't working. Thanks for the patch!