search

softlayer / softlayer-object-storage-python

SoftLayer Object Storage Python Client
Other
19 stars 30 forks source link

Added another MIME type for directory detection #5

Closed SecurityForUs closed 11 years ago

SecurityForUs commented 11 years ago

Per OpenStack documents here: http://docs.openstack.org/trunk/openstack-object-storage/developer/content/pseudo-hierarchical-folders-directories.html

To take advantage of this feature, the directory marker objects must also be created to represent the appropriate directories. The following additional objects need to be created. A good convention would be to create these as zero- or one-byte files with a Content-Type of application/directory.

I left in the original MIME type for backwards-compatibility, but "application/directory" is the standard, and it's also how it's shown via the OpenStorage control panel.

CrackerJackMack commented 11 years ago

Good catch! I reviewed the merge and it appears that the appropriate mime-type is used when creating directories, just not in the is_dir() function. If you could fix the doc block along with it, I will merge this ASAP.

SecurityForUs commented 11 years ago

Per your request I fixed the doc page and I also modified the comment block in the function as well.

CrackerJackMack commented 11 years ago

Perfect thanks! Wanted to be sure you got credit for the whole fix.