Closed SecurityForUs closed 11 years ago
Either the diff viewer is messed up or you used tabs?
im not sure what you mean. the commits were loading fine for me via github
I used tabs in some of them apparently, sorry about that. I fixed it w/ spaces now and it should be fine.
Didn't catch that one, sorry about that.
I'm going to close this pull request not because it wasn't good, but because there was one additional case that we found and wanted to support as well. If you look at the code and at the tests that we added, you can see why. Thanks for your input. We really appreciate it.
While I don't think the fix is 100% 'Pythonic', it reflects the fact that there are multiple scenarios for 'Range' header: http://docs.openstack.org/trunk/openstack-object-storage/developer/content/retrieve-object.html
I wrote a testing function that simulates this to demonstrate how it works in comparison to the above link: