Add search for virtual disk image

softlayer / softlayer-ruby

http://softlayer.github.io/softlayer-ruby/

MIT License

54 stars 35 forks source link

Add search for virtual disk image #114

Closed mbhavya closed 7 years ago

mbhavya commented 8 years ago

This PR adds search with id functionality for VDIs (similar to search_with_id in VirtualServer).

Hi @SLsthompson , Could you please take a look and let me know if this PR needs more work before merging ? Thanks Bhavya ( @mbhavya )

coveralls commented 8 years ago

Coverage remained the same at 99.762% when pulling 4a82864c16fc23426f8e754874d285d92a5904e0 on bhavyaaha:vdiSearch into 0adc0e4f26251252be7d29234bb2c8758da83504 on softlayer:master.

coveralls commented 7 years ago

Coverage increased (+0.06%) to 99.821% when pulling 7341380907536391c69ad27013fdb28da511577c on mbhavya:vdiSearch into 0adc0e4f26251252be7d29234bb2c8758da83504 on softlayer:master.

renier commented 7 years ago

@SLsthompson FYA, the checks in this pull request fails only when testing on JRuby19, because of the coveralls->tins dependency (tins requires Ruby 2.0).

So, should we remove jruby19 testing from .travis.yml? Or should we use something other than coveralls for the coverage testing? e.g. simplecov

coveralls commented 7 years ago

Coverage remained the same at 99.762% when pulling e2f1f635b6db8e40b656d89ac23303a72a1a3c43 on mbhavya:vdiSearch into 0adc0e4f26251252be7d29234bb2c8758da83504 on softlayer:master.