search

softlayer / softlayer-ruby

http://softlayer.github.io/softlayer-ruby/
MIT License
54 stars 35 forks source link

Allow the ability to set the timeout for API calls #44

Closed ju2wheels closed 10 years ago

ju2wheels commented 10 years ago

We would like to be able to set the HTTP related timeouts for the underlying Net::HTTP or XMLRPC client of SoftLayer::Service as we are having what looks like like timeouts related to the SL API in vagrant-softlayer: https://github.com/audiolize/vagrant-softlayer/issues/16

Unless I missed it in the code, neither the 1.x or 2.x releases seem to allow this.

SLsthompson commented 10 years ago

Please look at the propose "version 2.2.0" branch on Github (https://github.com/softlayer/softlayer-ruby/tree/Version_2.2.0).

It allows you to specify a timeout when you create a Client. That timeout is then picked up when any services attached to that client create their XMLRPC clients.

I'm not sure how this will play with the way Vagrant wants to handle timeouts so if you need this to work another way, let's work on it.

ju2wheels commented 10 years ago

That works ok, had to switch to using SoftLayer::Client instead of the Service directly but thats no big deal, seems thats where you guys are heading anyway. Noticed that ::SoftLayer::SoftLayerAPIException was dropped along the way from 1.x to 2.x, was this replaced with stock Exceptions.

ju2wheels commented 10 years ago
SLsthompson commented 10 years ago

Yes. SoftLayer API Exception was abandoned in favor of the built-in RuntimeException.

SLsthompson commented 10 years ago

I updated the Version_2.2.0 branch to include a fix for the Object Mask Parser as well.