softlayer / softlayer-ruby

http://softlayer.github.io/softlayer-ruby/
MIT License
54 stars 35 forks source link

[bug] ObjectMaskParser has undefined variable propertyName #45

Closed ju2wheels closed 10 years ago

ju2wheels commented 10 years ago
==> tempvagrantbuildparallel1: An error occurred. The error will be shown after all tasks complete.
An error occurred while executing multiple actions in parallel.
Any errors that occurred are shown below.

An error occurred while executing the action on the 'tempvagrantbuildparallel1'
machine. Please handle this error then try again:

Vagrant returned an exception while calling the SoftLayer API.

Exception class: VagrantPlugins::SoftLayer::Errors::SLApiError
Exception message: Vagrant returned an exception while calling the SoftLayer API.

Exception class: NameError
Exception message: undefined local variable or method `propertyName' for #<SoftLayer::ObjectMaskParser:0x00000003f7fd20>

An error occurred while executing the action on the 'tempvagrantbuildparallel'
machine. Please handle this error then try again:

Vagrant returned an exception while calling the SoftLayer API.

Exception class: VagrantPlugins::SoftLayer::Errors::SLApiError
Exception message: Vagrant returned an exception while calling the SoftLayer API.

Exception class: NameError
Exception message: undefined local variable or method `propertyName' for #<SoftLayer::ObjectMaskParser:0x000000034e10d0>

https://github.com/softlayer/softlayer-ruby/blob/96ecddb8bd630c89e8b5b64af0fa5d6d0f8923bb/lib/softlayer/ObjectMaskParser.rb#L61

SLsthompson commented 10 years ago

Please note that version 3.0 has a significant re-working of the Object Filter functionality. If you create your own object filters, Please get the 3.0 branch soon and check it against your code : https://github.com/softlayer/softlayer-ruby/tree/v3.0

ju2wheels commented 10 years ago

Ive switched us over to using the mask strings "mask[]" as part of the transition to 2.2.0 and dropped all the old instances where we used hashes for masks when using object_mask. Anything else you think would be needed? Ill give it a try today.

SLsthompson commented 10 years ago

You're working with Object Masks. I was referring to Object Filters (in other words I was confusing the issue). Object filters are a mostly-un-documented aspect of the system (though @underscorephil is hard at work on documentation). Chances are you've not run into them directly... but if you have, you'll want to test them against the 3.0 branch ASAP. :-)

ju2wheels commented 10 years ago

Initial builds using v3.0 look ok on my end.