Fix incorrect rdoc for simple case where sl_attr is specified with two args - Githubissues

softlayer / softlayer-ruby

http://softlayer.github.io/softlayer-ruby/

MIT License

54 stars 35 forks source link

Fix incorrect rdoc for simple case where sl_attr is specified with two args #98

Closed cmarkle closed 9 years ago

cmarkle commented 9 years ago

This deals with the simple part of issue #97 where sl_attr with two args would cause rdoc to generate two attributes where only one was intended. The question of what to do about sl_dynamic_attr as discussed in #97 remains open for now awaiting more discussion.

coveralls commented 9 years ago

Coverage decreased (-0.0%) to 99.76% when pulling 1b3792c6ee21b8f69c780754eb7daebeae227863 on cmarkle:rdoc-fix into 8882c355f29594272736daf2161b8127f8ff3049 on softlayer:master.

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.76% when pulling de35c81f58b2563300fe18475daa2f7d9ffe6f23 on cmarkle:rdoc-fix into 8882c355f29594272736daf2161b8127f8ff3049 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling d86c3c9c892db1b6f82e68d88aa352c56e6231af on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling b9f787023eccfc080c2111a98ad3b4f4b6439f5c on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling b9f787023eccfc080c2111a98ad3b4f4b6439f5c on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling a59b81f8533fcb51ddf85ae04cea26c49ca94a37 on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling fffb5cc22d308ee1d3b0f87d6d026d05f5cc26ac on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

coveralls commented 9 years ago

Coverage remained the same at 99.76% when pulling 1fdabcde907a3975b80d409a61d7f95534a603fb on cmarkle:rdoc-fix into d5e6b4c647c0a05240fb9767d94d53f7ed94fcf7 on softlayer:master.

cmarkle commented 9 years ago

This pull request is ready. I think all items we've discussed in issue #97 are covered here. Can you please review and merge if satisfactory? Thanks!