softlion / XamSvg-Samples

Samples for Xamarin Svg enterprise cross platform and full featured Svg image control
https://vapolia.eu
MIT License
24 stars 4 forks source link

[Forms][iOS] SVG file not selected when it should be #7

Closed toussam closed 4 years ago

toussam commented 6 years ago

Hi Benjamin, :)

Description

As you know, we are using your component and we noticed an issue that may be related to it.

To summarize our situation, we created a custom control on which we binded some data thanks to the BindableProperties. Inside this control, we set an SVG that is selectable and when it's the case, a part of the file must fill itself.

Everything is working fine except when we are using the custom control into a ListView's DataTemplate. Indeed, some items are not correctly display (must be filled, but aren't).

Steps to Reproduce

I created a sample to reproduce the related issue. Into this last one, you will find a simple ListView displaying a .SVG file (a star) by using a custom control. I tried to display the svg with another component and it worked fine.

  1. lunch the given sample on an iOS device
  2. scroll a bit down and / or up
  3. observe that some stars are not filled when they should be

Basic Information

Reproduction Link

Sample.zip

I thank you in advance for everything and wish you a great week !

toussam commented 5 years ago

Hi @softlion ,

Would you have some time to review our issue ? :)

softlion commented 5 years ago

Will look

toussam commented 5 years ago

Hi @softlion ,

Any update ? ;)

Best regards,

softlion commented 5 years ago

try yo set isasync to false. sometimes xamarin forms has issues refreshing a ui zone asynchronously.

toussam commented 5 years ago

I am not sure what you are referring to... Are you talking about the SvgImage's IsLoadAsync ?

The only thing I could find about an IsAsync property is a WPF one using through the binding system.

softlion commented 5 years ago

Yes IsLoadAsync sorry

toussam commented 5 years ago

Setting it to False or True is not changing anything.

Another idea maybe ?

toussam commented 5 years ago

Hi Benjamin,

I know that you must be very busy, but could you help me with this issue ?

I thank you in advance for everything !

softlion commented 4 years ago

Command won't work inside a listview item, because of the way gestures are handled in xamarin forms. This is not a XamSvg issue. Use DebugListView.ItemTapped instead.