softmaterialslab / nanoconfinement-md

This code allows users to simulate ions confined between material surfaces that are nanometers apart, and extract the associated ionic structure.
Apache License 2.0
5 stars 13 forks source link

Crystal pack #137

Closed nasimanousheh closed 4 years ago

nasimanousheh commented 4 years ago

@jadhao and @kadupitiya In interface.cpp, we can pack the ions like crystal.I updated the examples (not all of them).

There are some issues:

For Positive ion valency (e)= +3 which makes the box full: Positive ion diameter (nm): 0.714; Negative ion diameter (nm): 0.714; Negative ion valency (e) : -1; Concentration (M): 0.9; Confinement size for nano-hub between 2.2 to 4 nm. (less than 2.2 does not work);

I prefer to keep random pack, in some cases like positive ion vacancy = +3 we can switch to crystal pack.

kadupitiya commented 4 years ago

@jadhao: I am approving this to check with nanoHUB.