search

softmaterialslab / nanoconfinement-md

This code allows users to simulate ions confined between material surfaces that are nanometers apart, and extract the associated ionic structure.
Apache License 2.0
5 stars 13 forks source link

modified the program to support the rappture #44

Closed kadupitiya closed 6 years ago

kadupitiya commented 6 years ago

modified the program to support the rappture

kadupitiya commented 6 years ago

@jadhao please have a look. Thank you!

smarru commented 6 years ago

@kadupitiya I think this has all your iterations from workspace. I suggest you squash all commits into one so it will be easy to review. An example is here - https://github.com/todotxt/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

jadhao commented 6 years ago

@smarru we have checked the simulations on nanohub, local, and cluster...I am happy to merge it without a detailed review. do you want to do that (if yes, then I accept as is, otherwise we will collapse the commits as you say and wait for your approval?

smarru commented 6 years ago

@jadhao @kadupitiya this changes are great, i also tried it on my workspace and its working well. Squashing is only to help review. If you reviewed the functionality instead, then its not needed. Thanks for checking.